-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: implement quote seed column #512
Merged
nicor88
merged 5 commits into
dbt-labs:main
from
davidbridgwood:implement_quote_seed_column
Dec 4, 2023
Merged
fix: implement quote seed column #512
nicor88
merged 5 commits into
dbt-labs:main
from
davidbridgwood:implement_quote_seed_column
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbridgwood
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix,
nicor88 and
svdimchenko
as code owners
November 16, 2023 18:30
davidbridgwood
changed the title
Implement quote seed column
fix: implement quote seed column
Nov 16, 2023
@davidbridgwood looks good to me, could you add some functional tests to cover this scenario? |
Hey @nicor88, have had a go at adding a functional test. |
@Jrmyy could you have a look too? |
nicor88
previously approved these changes
Nov 20, 2023
Jrmyy
reviewed
Nov 21, 2023
@davidbridgwood did you see @Jrmyy comments? |
Jrmyy
reviewed
Nov 24, 2023
Jrmyy
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #507
Implements
quote
method and passesquote_config
through inquote_seed_column
.To get round the issue where backticks are required in some statements when columns are prefixed with underscores, but double-quotes are needed everywhere else i've added a
quote_character
attribute which defaults to double-quote and pass backticks when required.Models used to test - Optional
Checklist