Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement quote seed column #512

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

davidbridgwood
Copy link
Contributor

Description

resolves #507

Implements quote method and passes quote_config through in quote_seed_column.

To get round the issue where backticks are required in some statements when columns are prefixed with underscores, but double-quotes are needed everywhere else i've added a quote_character attribute which defaults to double-quote and pass backticks when required.

Models used to test - Optional

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@davidbridgwood davidbridgwood changed the title Implement quote seed column fix: implement quote seed column Nov 16, 2023
@nicor88
Copy link
Contributor

nicor88 commented Nov 17, 2023

@davidbridgwood looks good to me, could you add some functional tests to cover this scenario?
Have a look at this https://github.com/dbt-athena/dbt-athena/blob/main/tests/functional/adapter/test_seed_by_insert.py to understand more what to add.

@davidbridgwood
Copy link
Contributor Author

Hey @nicor88, have had a go at adding a functional test.

@nicor88
Copy link
Contributor

nicor88 commented Nov 20, 2023

@davidbridgwood 💯

@Jrmyy could you have a look too?

nicor88
nicor88 previously approved these changes Nov 20, 2023
@nicor88 nicor88 self-requested a review November 22, 2023 15:39
@nicor88
Copy link
Contributor

nicor88 commented Nov 22, 2023

@davidbridgwood did you see @Jrmyy comments?

@nicor88 nicor88 dismissed their stale review November 27, 2023 13:56

Waiting for @Jrmyy review!

@nicor88 nicor88 merged commit bae9fce into dbt-labs:main Dec 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seeds with columns starting with underscore fail
3 participants