-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump dbt to 1.7.0 #488
Conversation
4e98c8a
to
b425ffb
Compare
11ebab8
to
be34f2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicor88 it's great you've added dbt-core 1.7.0 support! I've left just minor comments about commented out code
6b4b58c
to
be500e8
Compare
@Jrmyy and @svdimchenko another review please 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to add tests ✅
Description
Bump dbt to 1.7.0 and see what we break, close #454
Added functional tests for dbt docs and macro overwride.
Breaking changes
Based on the code base we overwrite only get_catalog macro, but we don't overwrite, BaseAdapter.get_catalog(), but we overwrite a method that is called by get_catalog.
TODO
get_catalog_relations
that callget_catalog_relations_where_clause_sql
(not necessary for dbt-athena, if we use glue)References:
Checklist