Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: persist_docs too long comment #485

Merged
merged 4 commits into from
Nov 9, 2023
Merged

fix: persist_docs too long comment #485

merged 4 commits into from
Nov 9, 2023

Conversation

Jrmyy
Copy link
Contributor

@Jrmyy Jrmyy commented Nov 2, 2023

Description

Models used to test - Optional

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@Jrmyy Jrmyy force-pushed the fix-persist-docs-too-long-columns branch from 4f3ff79 to e7a058e Compare November 2, 2023 11:06
nicor88
nicor88 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@nicor88 nicor88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems that we still use clean_sql_comment, do you think that is still needed?

@nicor88
Copy link
Contributor

nicor88 commented Nov 9, 2023

@Jrmyy shall we merge this one?

@Jrmyy Jrmyy marked this pull request as ready for review November 9, 2023 07:42
@Jrmyy Jrmyy merged commit 84381e7 into main Nov 9, 2023
8 checks passed
@Jrmyy Jrmyy deleted the fix-persist-docs-too-long-columns branch November 9, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svdimchenko svdimchenko svdimchenko approved these changes

@nicor88 nicor88 nicor88 approved these changes

@jessedobbelaere jessedobbelaere Awaiting requested review from jessedobbelaere

@mattiamatrix mattiamatrix Awaiting requested review from mattiamatrix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jrmyy @nicor88 @svdimchenko