Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add argument support to dbt commands (dbt clean & dbt deps) #53

Conversation

Aostojic
Copy link
Contributor

This enhancement will allow the dbt-clean and dbt-deps hooks to take arguments for global and cmd flags.
This addresses issue 39 by allowing the project-dir flag to be added to the dbt clean and dbt deps commands
Example:

  • id: dbt-clean
    args: ["--cmd-flags", "++project-dir", "./transform/dbt"]

@samLozier
Copy link

Is there anything that a contributor could help with that would move this PR forward?

@tomsej
Copy link
Contributor

tomsej commented Jan 24, 2022

Sorry guys. I was solving some family issues. Will look into this tomorrow!

@tomsej
Copy link
Contributor

tomsej commented Jan 26, 2022

Thank you @Aostojic!!! I was tough on myself and set the test coverage to 100%. Seems that code you wrote is not covered. Can you write tests? Or should I do it?

@Aostojic
Copy link
Contributor Author

Thank you @Aostojic!!! I was tough on myself and set the test coverage to 100%. Seems that code you wrote is not covered. Can you write tests? Or should I do it?

@tomsej I've fixed the test coverage.

@samLozier
Copy link

Is there a plan for this to get merged any time soon? It would help a lot for me.

@jaklan
Copy link

jaklan commented Mar 17, 2022

@tomsej it seems the PR is just waiting for merging, can we have it done?

@dalebradman
Copy link

@tomsej likewise! Would support monorepo's massively

@inkeysolutions
Copy link

@tomsej any progress on this please ... ?
It has been nearly 6 months since the code is ready.
Thanks :-)

@ssassi ssassi merged commit 15a71f8 into dbt-checkpoint:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants