Fix income endpoint if the API returns no result #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the income spec called the earnings instead of the income endpoint.
Generated by 🚫 Danger |
dblock
reviewed
Feb 1, 2020
| context 'invalid symbol', vcr: { cassette_name: 'income/invalid' } do | ||
| subject do | ||
| client.earnings('INVALID') | ||
| client.income('INVALID') |
|
@brunjo any interested in becoming a co-maintainer here? Making the next release? If yes, send me an email to dblock at dblock dot org with your rubygems username/email. |
|
@dblock Sorry for the late reply. I'm happy to help with that. I'll send you an email in a minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client.income('nsrgy')returned the following error because the API doesn't return any results.