Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSL options for OpenSSL v3 #113

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Conversation

agrberg
Copy link
Collaborator

@agrberg agrberg commented Jul 20, 2022

fixes #112

@agrberg agrberg force-pushed the update_ssl_options branch from 05d7f11 to 8f864c1 Compare July 20, 2022 16:35
@agrberg agrberg requested a review from dblock July 20, 2022 18:00
Copy link
Owner

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Needs some cleanup here and there.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
`ca_file` and maybe `ca_path` are handled differently under OpenSSL v3 than in v1. It is a safer approach to leave these values out and allow the system to handle default behavior while keeping the configuration available for developers/projects that need it.
@dblock
Copy link
Owner

dblock commented Jul 21, 2022

Ooof I realized I merged it but CI didn't run. Care to take care of #116 first?

@agrberg agrberg deleted the update_ssl_options branch July 21, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workaround for Heroku's 22 stack's Faraday::SSLError (SSL_CTX_load_verify_file: system lib)
2 participants