Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better exception messages when we could not find proper executable - … #750

Merged
merged 1 commit into from
May 19, 2023

Conversation

fizyk
Copy link
Collaborator

@fizyk fizyk commented May 19, 2023

closes #598

Chore that needs to be done:

  • Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_numer either from issue tracker or the Pull request number

@fizyk fizyk force-pushed the file-not-found branch from cad1ed4 to 353ff4f Compare May 19, 2023 13:53
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -1.71 ⚠️

Comparison is base (9d314a2) 97.15% compared to head (353ff4f) 95.45%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   97.15%   95.45%   -1.71%     
==========================================
  Files          12       13       +1     
  Lines         387      396       +9     
==========================================
+ Hits          376      378       +2     
- Misses         11       18       +7     
Flag Coverage Δ
unittests 95.45% <66.66%> (-1.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pytest_postgresql/executor.py 91.66% <60.00%> (-1.89%) ⬇️
pytest_postgresql/factories/process.py 90.69% <60.00%> (-4.18%) ⬇️
pytest_postgresql/exceptions.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fizyk fizyk force-pushed the file-not-found branch from 353ff4f to 1d17def Compare May 19, 2023 14:30
@fizyk fizyk merged commit 066959a into main May 19, 2023
@fizyk fizyk deleted the file-not-found branch May 19, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileNotFoundError: [Errno 2] No such file or directory: 'pg_config'
2 participants