example/sun-checks #10
Conversation
dbelyaev
commented
Sep 15, 2023
dbelyaev
commented
- configure action to use sun_checks config
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,45 @@ | |||
| import java.util.Arrays; | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck> reported by reviewdog 🐶
Missing package-info.java file.
| @SpringBootApplication | ||
| public class Application { | ||
|
|
||
| public static void main(String[] args) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> reported by reviewdog 🐶
Missing a Javadoc comment.
| @SpringBootApplication | ||
| public class Application { | ||
|
|
||
| public static void main(String[] args) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> reported by reviewdog 🐶
Parameter args should be final.
| SpringApplication.run(Application.class, args); | ||
| } | ||
|
|
||
| private void DoReallyNothing() { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck> reported by reviewdog 🐶
Name 'DoReallyNothing' must match pattern '^[a-z][a-zA-Z0-9]*$'.
|
|
||
| private void DoReallyNothing() { | ||
| try { | ||
| var counter = 100; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.MagicNumberCheck> reported by reviewdog 🐶
'100' is a magic number.
| * @return some return | ||
| */ | ||
| @Bean | ||
| public CommandLineRunner commandLineRunner(ApplicationContext ctx) { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> reported by reviewdog 🐶
Parameter ctx should be final.
| @Bean | ||
| public CommandLineRunner commandLineRunner(ApplicationContext ctx) { | ||
| return args -> { | ||
| System.out.println("Let's inspect the beans provided by Spring Boot:"); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 80 characters (found 83).
| return args -> { | ||
| System.out.println("Let's inspect the beans provided by Spring Boot:"); | ||
|
|
||
| var LongString = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Porta lorem"; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 80 characters (found 167).
| return args -> { | ||
| System.out.println("Let's inspect the beans provided by Spring Boot:"); | ||
|
|
||
| var LongString = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Porta lorem"; |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.LocalVariableNameCheck> reported by reviewdog 🐶
Name 'LongString' must match pattern '^[a-z][a-zA-Z0-9]*$'.
dbelyaev
force-pushed
the
example/sun-checks
branch
from
a15e16a to
5cefcd9
Compare
