Make subs only remove self from subscription cache when disposing #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a check for subscriptions to make sure that when they are dissocing their cache key from the query cache that they are only removing themselves. In certain cases when reloading/re-rendering the app, subscriptions would be created and destroyed several times because each version of subscription destroyed the following one.
re-frame should always be using queries from the cache if they exist. This is a belt and suspenders check to make sure that always holds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check for subscriptions to make sure that when they are dissocing their cache key from the query cache that they are only removing themselves. In certain cases when reloading/re-rendering the app, subscriptions would be created and destroyed several times because each version of subscription destroyed the following one.
I still need to review this more before merging.