Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self-host compatibility using macrovich #325

Merged
merged 1 commit into from
May 28, 2017
Merged

Conversation

viebel
Copy link
Contributor

@viebel viebel commented Mar 11, 2017

This PR makes re-frame self-host compatible.
It means that re-frame can now be used inside KLIPSE (which is going super useful for sharing bugs, ideas and more...).

Here is a live demo.

Note: The self-host compatibility of re-frame depends on the self-host compatibility of re-agent that is achieved by reagent-project/reagent#283
image
.

@arichiardi
Copy link

Awesome! Also very good for using experimenting with lumo

@danielcompton
Copy link
Contributor

danielcompton commented Mar 12, 2017

Thanks for this, I'll need to review it carefully, but it should be ok. Here's the changes without whitespace diffs.

@viebel
Copy link
Contributor Author

viebel commented May 24, 2017

Any update on this PR @danielcompton ?

@danielcompton
Copy link
Contributor

danielcompton commented May 28, 2017

I'm ok to merge this for now, on the proviso that if it causes any problem in future versions of Clojure/ClojureScript or with other uses of re-frame then it'll be pulled out. So you can use it for things, and I don't anticipate us removing it, but at the moment supporting self-hosting is a non-goal, so don't treat it as being officially supported by re-frame.

@danielcompton danielcompton changed the base branch from master to develop May 28, 2017 22:54
@danielcompton danielcompton merged commit af6488b into day8:develop May 28, 2017
@danielcompton
Copy link
Contributor

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants