Dev christiaan sprint 2 Finished #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 23, 2024 15:56
…reen.py now when you open a project you come to the TemplateScreen.py and it only loads in the subset and the classes in the subset. Only when you go to the RelationChangeScreen.py the RelationChangeDomain.py starts loading the saved data of the project with all the lists showing a message that the data is being loaded.
…l errors in generating possible relation elements When an error occurs a warning is given and the possible relation with the error is ommited
added 27 commits
January 9, 2025 11:08
…slight restructuring of updating interface to dark mode and vis-versa
…ties in een folder bij de folder
…he list-classes function of the FDO ToolBox
…query-features function of the FDO ToolBox
…convert_SDF_file() instead of in each subfunction + made subfunctions private
…t_SDF_to_CSV with output folder as argument
… any other file actually
… rights. When installing with admin rights it gets installed in Program Files folder and by defual the pyvis library will try to create and write to the home directory but it can't when the app doesn't have admin rights. By default it doesn't and you shouldn't let it have admin rights. This work arround will change the current working directory of the python to %user_home%/OLTWizardProjects/, where the pyvis library is allowed to write, everytime the PyVisWrapper is called after the call the original current working directory is restored
each log line has the date, time and line and file where they happend added into the log file nog. it is set to DEBUG level now
…g: extra = {"timing": True}
Loading project details Validating documents Loading quicksaves Saving quicksaves Creating templates Generating possible relations classes Generating relations between objects Loading subsets Updating frontend in RelationChangeScreen add/removing existing relations? Converting SDF to csv files
There was a problem hiding this comment.
Copilot reviewed 130 out of 145 changed files in this pull request and generated no comments.
Files not reviewed (15)
- Domain/logger/OTLLogger.py: Evaluated as low risk
- Domain/SDFHandler.py: Evaluated as low risk
- Domain/database/SubsetDatabase.py: Evaluated as low risk
- Domain/step_domain/AssetChangeDomain.py: Evaluated as low risk
- GUI/dialog_windows/AddExternalAssetWindow.py: Evaluated as low risk
- Exceptions/NoIdentificatorError.py: Evaluated as low risk
- Domain/step_domain/ExportDataDomain.py: Evaluated as low risk
- .github/workflows/unittest.yml: Evaluated as low risk
- Domain/project/ProgramFileManager.py: Evaluated as low risk
- GUI/MainWindow.py: Evaluated as low risk
- Domain/Settings.py: Evaluated as low risk
- Domain/step_domain/HomeDomain.py: Evaluated as low risk
- Domain/step_domain/TemplateDomain.py: Evaluated as low risk
- Domain/project/ProjectFile.py: Evaluated as low risk
- Domain/global_vars.py: Evaluated as low risk
Comments suppressed due to low confidence (2)
GUI/Styling.py:28
- [nitpick] The method name
applyStylingshould follow PEP 8 naming conventions and be renamed toapply_styling.
def applyStyling(cls,app:QApplication , meipass):
Exceptions/FDOToolboxProcessError.py:11
- The comment on line 11 should be removed or updated to match the actual error message format used in the str method.
# "An error occured during FDO toolbox call: \nCall: {0} \nError:\n{1}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.