Add support for generating getters that return Optional

[bspeakmon]

This change adds support for the createOptionalGetters and gettersReturnOptional properties in SpecificCompiler, new as of Avro 1.9.

createOptionalGetters adds additional methods of the form Optional<sometype> getOptionalField() for each field.

gettersReturnOptional changes getters to return Optional, as in Optional<sometype> getField().

[davidmc24]

Cool, thanks for the pull request. I’ll take a look soon and get back to you.

On Wed, Oct 16, 2019 at 7:29 PM Ben Speakmon ***@***.***> wrote: This change adds support for the createOptionalGetters and gettersReturnOptional properties in SpecificCompiler, new as of Avro 1.9. createOptionalGetters adds additional methods of the form Optional<sometype> getOptionalField() for each field. gettersReturnOptional changes getters to return Optional, as in Optional<sometype> getField(). ------------------------------ You can view, comment on, or merge this pull request online at: #90 Commit Summary - add support for generating optional getters - add doc for optional getter field generation File Changes - *M* README.md <https://github.com/davidmc24/gradle-avro-plugin/pull/90/files#diff-0> (36) - *M* src/main/java/com/commercehub/gradle/plugin/avro/AvroBasePlugin.java <https://github.com/davidmc24/gradle-avro-plugin/pull/90/files#diff-1> (2) - *M* src/main/java/com/commercehub/gradle/plugin/avro/AvroExtension.java <https://github.com/davidmc24/gradle-avro-plugin/pull/90/files#diff-2> (2) - *M* src/main/java/com/commercehub/gradle/plugin/avro/Constants.java <https://github.com/davidmc24/gradle-avro-plugin/pull/90/files#diff-3> (2) - *M* src/main/java/com/commercehub/gradle/plugin/avro/DefaultAvroExtension.java <https://github.com/davidmc24/gradle-avro-plugin/pull/90/files#diff-4> (32) - *M* src/main/java/com/commercehub/gradle/plugin/avro/GenerateAvroJavaTask.java <https://github.com/davidmc24/gradle-avro-plugin/pull/90/files#diff-5> (36) - *M* src/test/groovy/com/commercehub/gradle/plugin/avro/OptionsFunctionalSpec.groovy <https://github.com/davidmc24/gradle-avro-plugin/pull/90/files#diff-6> (66) Patch Links: - https://github.com/davidmc24/gradle-avro-plugin/pull/90.patch - https://github.com/davidmc24/gradle-avro-plugin/pull/90.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#90?email_source=notifications&email_token=AADNKUOD6V6Y4FVOLMEKJDDQO6PUFA5CNFSM4JBSHDH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HSJYXDA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADNKUOSFSEAF4I267TGWIDQO6PUFANCNFSM4JBSHDHQ> .

-- David M. Carr [email protected]

[davidmc24]

Pull requests for features added in recent versions are awesome, since other people often notice these feature before I do, and they're things that usually clearly make sense to support in the plugin.

The things I generally look for in this type of review are:

• if there's any version compatibility impact
• if it's properly included in the documentation (readme, changelog)
• if it has adequate test coverage
• if the defaults are appropriate (match avro library's default handling and/or most common usage)
• if the naming matches the avro library
• if the extension and conventions are wired up properly
• matches existing conventions for plugin logging output
• correct usage of Input/Output

Man, listing all that makes Gradle plugin development sound complicated.

Regardless, you did great with this pull request. I'm going to merge it. I've got a couple minor changes I'm planning on making in the next week or so, and then I'll include this in the next release.

Thanks again for the pull request!