Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add colors and fixed width to methods #26

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Add colors and fixed width to methods #26

merged 2 commits into from
Nov 7, 2019

Conversation

railken
Copy link
Contributor

@railken railken commented Nov 4, 2019

preview:

img

@davidhsianturi
Copy link
Owner

Thanks. The component name doesn't make sense to me. Make it something like "HttpMethods.vue" or "AvailableMethods.vue" and please add the method PATCH and OPTIONS too.
This the result if I have Route::apiResource

Screen Shot 2019-11-05 at 03 06 20

@railken
Copy link
Contributor Author

railken commented Nov 4, 2019 •
edited
Loading

I will surely fix these methods on the next commit and rename the component as you asked.

As for the bug you mentioned, i have no idea how to solve a "request" that have more than one methods. Shouldn't those request be divided?

Also, OPTIONS is usually used for cors and i see no api docs that use that. Shouldn't this avoided like HEAD?

@railken
Copy link
Contributor Author

railken commented Nov 6, 2019

Preview multiple methods
img

@davidhsianturi
Copy link
Owner

Thanks.

@davidhsianturi davidhsianturi merged commit ea8e881 into davidhsianturi:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@railken @davidhsianturi