Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add groundwork for data flag & outlier marking #22

Merged
merged 49 commits into from
Jan 21, 2021
Merged

Add groundwork for data flag & outlier marking #22

merged 49 commits into from
Jan 21, 2021

Conversation

davidclemens
Copy link
Owner

@davidclemens davidclemens commented Jan 14, 2021 •
edited
Loading

This PR adds the basics for data flags & outlier marking by implementing the underlying architecture.

It is part of DataKit and linked to gearDeployments with the markOutliers method.

Further implementation into the plot methods and the subsequent data analysis is still required.

This PR is part of #3 and #4.

@davidclemens
Start adopting new GearKit dataPool storage
3d3da83
@davidclemens
Fix minor bugs
391f7b0
@davidclemens
Add deviceDomain
5f1a9ba 
Also add abbreviations to worldDomain.
@davidclemens
Add new findVariable method
bc7a403 
Closes #17.
@davidclemens
Add ability to configure measurementDevices
742d18a 
Closes #18.
@davidclemens
Minor changes
e39cb4a
@davidclemens
Add duration variables
3e0c882
@davidclemens
Minor changes
720bd07
@davidclemens
Make metadata output consistent
9c244db 
- Also improve the performance of by only accessing the get.Index method once.
@davidclemens
Add new calibration method
4fd364b
@davidclemens
Add new unit test
c453465 
Part of #9.
@davidclemens
Initial outlier marking implementation
de0cacd 
Part of #3.
@davidclemens
New validFlag class
a5871a3 
Part of #4.
@davidclemens
New dataFlag & sparseBitmask class
da782e4 
Also includes some new unit tests.

Part of #4 & #9.
@davidclemens
Overload builtin methods for sparseBitmask
7491dd7
@davidclemens
Minor changes
51ec828
@davidclemens
Add data flags to outlier marking
4e169fc 
Part of #3 and #4.
@davidclemens
Switch to using arrayhom
1de9c0d
@davidclemens
Overload builtin methods & minor fixes
c485cb2
@davidclemens
Add data flags to fetch data methods
a19e5f4 
Part of #4.
@davidclemens
Add setFlag method to dataPool
e1b4564
@davidclemens
Add isFlag method to dataFlag
2e38d28
@davidclemens
Refactor setBit algorithm to increase speed
fd15e5e
@davidclemens
Add method abbreviation2devicedomain to deviceDomain
89817fe
@davidclemens
Fix bug
60bb10a 
Removing empty groups caused the indexes no longer to be the correct size when used in the relative time calculations. Fixed by moving the block to the end.
@davidclemens
Fix bug
cf17142 
If an axis held other objects, such as text, they'd be returned as a chart as well. This is now fixed.
@davidclemens
Add missing deviceDomain to analytical samples
0c42c34
@davidclemens
Fix bug
6cd541b
@davidclemens
Improve flag setting & other fixes
a9718cb
@davidclemens
Add options & grey out set dataFlags
df46152
@davidclemens davidclemens added new feature New feature or request UI User interface kit: GearKit kit: DataKit labels Jan 14, 2021
@davidclemens davidclemens self-assigned this Jan 14, 2021
@davidclemens davidclemens added this to the v0.1b1 milestone Jan 14, 2021
@davidclemens davidclemens marked this pull request as draft January 19, 2021 22:44
@davidclemens
Merge development
a8d05cf
@davidclemens
Fixed test failures
daa552b
@davidclemens
Add isequal method to dataPool
f26cdb4
@davidclemens
Implement gearDeployment save/load interface
0e152c2 
Closes #5
@davidclemens
Add initial unit test to save/load interface
a1384f6
@davidclemens
Restructure save/load interface
69b21be 
- save/load filenames are now stored in the object enabeling saving to disk e.g. during outlier marking
- loadobj has moved to the superclass `gearDeployment`
- new load interface for `gearDeployment` subclasses

Part of #5
@davidclemens
Minor changes
7da58e7
@davidclemens
Add automatic saving to markQualityFlags
27aaab4
@davidclemens
Overload ==/eq for sparseBitmask & dataFlag
5b4c4d1
@davidclemens
Add optional color input to dataBrushWindow constructor
c137cc1
@davidclemens
Improve markQualtiyFlag
0aad8ed 
- previous flags are now restored and shown in the UI
- minor visual tweaks
@davidclemens
Improve plot for gearDeployment
6d3425f
@davidclemens davidclemens marked this pull request as ready for review January 21, 2021 12:13
@davidclemens davidclemens merged commit 9665ba8 into development Jan 21, 2021
@davidclemens davidclemens deleted the refactor-outlier-marking branch January 21, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidclemens davidclemens

Labels
kit: DataKit kit: GearKit new feature New feature or request UI User interface
Projects
None yet
Milestone
0.1.0b1
Development

Successfully merging this pull request may close these issues.
1 participant
@davidclemens