Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes regression in resource list component #15

Merged
merged 5 commits into from
Sep 20, 2018

Conversation

cspanring
Copy link
Contributor

@davidbilling thanks for merging! and sorry for the trouble, should've caught this in #14.

@cspanring
Copy link
Contributor Author

@davidbilling additional changes to make ember-try pass on travis:

@davidbilling
Copy link
Owner

@cspanring Thanks, I did a update with Ember-cli-update to 3.4, but that was revoced and something when sideways when reverting it. I have not had any time looking into it.
Really appreciate that you trying to fix the ember:try test!

@cspanring
Copy link
Contributor Author

all tests in ember-try are now passing, except LTS 2.16, which is not in the ember-try config and I'm not sure why travis is trying to run it.

@davidbilling
Copy link
Owner

@cspanring It is in travis.yml I think...
env: EMBER_TRY_SCENARIO=ember-lts-2.16

@cspanring
Copy link
Contributor Author

trying a few combinations to make travis happy, will squash the commits once I found the correct combo...

@davidbilling
Copy link
Owner

🥇 Thanks!

@cspanring
Copy link
Contributor Author

@davidbilling all set, ember-try and travis are now happy

@davidbilling davidbilling merged commit 08177f9 into davidbilling:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants