Clarify CLI syntax for multi-value arguments #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good change, but the tests are failing since they expect the original syntax. if you can get them passing I can merge/release. |
Bluewind
force-pushed
the
multiple-argname-clarification
branch
from
6d207c6 to
ed10c0d
Compare
GLI will not strip comma characters from the end of arguments. If a user is following the help syntax for a multi-value argument, the first to N-1 values parsed will be incorrect (have an unstripped comma at the end of the value). Solve this by printing the argument name only once, followed by '...' directly. This is similar to the behaviour of git. Signed-off-by: Florian Pritz <[email protected]>
Bluewind
force-pushed
the
multiple-argname-clarification
branch
from
ed10c0d to
ce529e9
Compare
|
I've fixed the tests now. |
|
Released as 2.19.0 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLI will not strip comma characters from the end of arguments. If a user
is following the help syntax for a multi-value argument, the first to
N-1 values parsed will be incorrect (have an unstripped comma at the
end of the value). Solve this by printing the argument name only once,
followed by '...' directly. This is similar to the behaviour of git.
Signed-off-by: Florian Pritz [email protected]