Improve the cosmetics of the main panels in the application #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main difference here being that I downplay the scrollbars (they always stand out way too much for applications that are intended to be keyboard-first) and also drop the background-tint nonsense in Textual's builtin OptionList, as it then puts it in a different styling category as the scrollbars (as best as I can see there's no direct support for a background-tint for them). Overall I feel this commit makes things feel more smoother and consistent.
davep
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks the style of the main three panels that get focus in the application. The main changes being:
OptionList, when it has focus. Instead use a colour that can also be used to style the scrollbars (as best as I can see there's no easy way tobackground-tinta scrollbar, probably without actually messing with scrollbar widgets themselves).Overall I feel these changes make the mains screen feel... smoother.