Handle unknown collections #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I can't recreate it myself, looking at #104 it would appear that Raindrop can be got into a state where the API will report that a group has collections within it that don't actually exist any more. This commit seeks to ignore such collection IDs. So, with this change, a collection ID that isn't known to us is treated as if it doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off what is reported in #104 it would appear that the Raindrop API can end up reporting that a group has collections where the collection doesn't actually exist. It's unclear how this situation can arise, and I can't personally make it happen.
However, whatever the cause, a collection within a group where the collection doesn't exist any more should be a collection to ignore, to pretend it doesn't exist. This PR seeks to implement that.
Fixes #104.