Skip to content

Commit

Permalink
🐛 Don't allow editing of *any* uploaded file
Browse files Browse the repository at this point in the history
See #123.
  • Loading branch information
davep committed Jan 28, 2025
1 parent 4ac1f5d commit 0062256
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 5 deletions.
9 changes: 9 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Braindrop ChangeLog

## Unreleased

**Released: WiP**

- Extended the disabling of edits to any Raindrop associated with a file
that has been uploaded to `raindrop.io`. In testing it seems the data loss
happens with any Raindrop with an `up.raindrop.io` domain.
([#123](https://github.com/davep/braindrop/issues/123))

## v0.7.0

**Released: 2025-01-27**
Expand Down
11 changes: 6 additions & 5 deletions src/braindrop/app/screens/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -674,12 +674,13 @@ async def action_edit_raindrop_command(self) -> None:

# For the moment, don't allow editing of uploaded images.
# https://github.com/davep/braindrop/issues/123
if raindrop.type == "image":
if raindrop.domain == "up.raindrop.io":
self.notify(
"Editing of Raindrops that are images can cause the image to be lost. "
"While I investigate why this is I'm disabling the editing of any "
"Raindrop that is an image type.",
title="Editing if images is disabled",
"There seems to be a problem with the Raindrop API where, "
"if you modify a Raindrop associated with an uploaded file, "
"the uploaded file is lost.\n\n"
"To ensure your file isn't lost this edit is not permitted.",
title="Editing of uploads disabled",
severity="warning",
timeout=8,
)
Expand Down

0 comments on commit 0062256

Please sign in to comment.