-
Notifications
You must be signed in to change notification settings - Fork 362
Conversation
Hi @aroramrinaal , thanks for your contribution! Regarding the PR title and commits, we are trying to follow conventional commits specification for the commits and In addition, I see the tests don't pass in the travis build. |
c223d15
to
b2ca076
Compare
@myishay I think you wanted to ping me 👋 I think I missed those zsh completion changes because I ran tests on some other folder. This new patch should take care of that! For reference: spf13/cobra#1690 According to the PR
I have fixed the commit messages. Also divided changes:
Let me know if something needs a second look |
I also updated the PR title to match the commit message |
You are correct! I realized it only now 😅 |
No worries at all! Everything should be good to go, although feel free to let me know if there are any changes I should make. |
LGTM! |
Description
Bumps
cobra
version fromv1.1.3
tov1.5.0
Changes
None required as far as I can tell. Build process is successful and
go run main.go
works.Issue
Closes #697