-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight tested and unverified companies in search results and company single pages #451
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! Such a cool feature. I've left a small comment.
|
||
return ( | ||
'<span><strong>' + | ||
(name_hs.length === 1 ? name_hs[0].snippet : d.name) + | ||
(d.quality === 'tested' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Thanks for checking. The icon really shouldn't be clickable itself. I'll have to look into that. |
0076f59
to
a0161e0
Compare
Genuinely not sure how we could fix this. The documentation for the issue says that this applies to elements that "can be clicked with a pointing device" and "An element is clickable if it has an The icon doesn't have an I wasn't even able to get rid of the issue by setting So yeah, no idea what to do here. For reference: axe doesn't complain about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this! Seems more like it's a problem on Firefox' side, especially if axe doesn't complain. I say: Let's merge and recheck this with future FF (and axe) versions.
This needs to be merged before datenanfragen/data#773.