Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight tested and unverified companies in search results and company single pages #451

Merged
merged 2 commits into from
Nov 27, 2020

Conversation

baltpeter
Copy link
Member

This needs to be merged before datenanfragen/data#773.

@cypress
Copy link

cypress bot commented Oct 14, 2020



Test summary

40 0 4 0


Run details

Project website
Status Passed
Commit a0161e0
Started Nov 27, 2020 4:07 PM
Ended Nov 27, 2020 4:10 PM
Duration 02:18 💡
OS Linux Debian - 10.3
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@mal-tee mal-tee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Such a cool feature. I've left a small comment.


return (
'<span><strong>' +
(name_hs.length === 1 ? name_hs[0].snippet : d.name) +
(d.quality === 'tested'
Copy link
Member

@mal-tee mal-tee Nov 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FF's a11y checking tool doesn't like this:
grafik

@baltpeter
Copy link
Member Author

Interesting. Thanks for checking. The icon really shouldn't be clickable itself. I'll have to look into that.

@baltpeter baltpeter closed this Nov 7, 2020
@baltpeter baltpeter reopened this Nov 7, 2020
@baltpeter baltpeter force-pushed the b_unverified-companies branch from 0076f59 to a0161e0 Compare November 27, 2020 16:02
@baltpeter
Copy link
Member Author

Genuinely not sure how we could fix this. The documentation for the issue says that this applies to elements that "can be clicked with a pointing device" and "An element is clickable if it has an onclick event handler defined."

The icon doesn't have an onclick handler. I didn't find a way to communicate to Firefox that this element isn't clickable (itself). Setting role="figure" or role="img" doesn't change anything. Neither does setting pointer-events: none; (this also breaks the title text, so not an option anyway). Setting tabindex="0" on option div (which is actually supposed to be clickable) doesn't help either.

I wasn't even able to get rid of the issue by setting tabindex="0" on the icon itself as the issue description suggests (this also isn't actually an option as that would make the accessibility of the search bar worse imo).

So yeah, no idea what to do here. For reference: axe doesn't complain about that.

Copy link
Member

@mal-tee mal-tee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this! Seems more like it's a problem on Firefox' side, especially if axe doesn't complain. I say: Let's merge and recheck this with future FF (and axe) versions.

@baltpeter baltpeter merged commit 602f6ab into master Nov 27, 2020
@baltpeter baltpeter deleted the b_unverified-companies branch November 27, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants