Skip to content

Commit

Permalink
[Refactor][Connector] Refactor connector config
Browse files Browse the repository at this point in the history
  • Loading branch information
zixi0825 committed Dec 6, 2024
1 parent 8c3c9ec commit 1e94ed0
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 321 deletions.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
import io.datavines.common.datasource.jdbc.BaseJdbcDataSourceInfo;
import io.datavines.connector.api.DataSourceClient;

import java.sql.DatabaseMetaData;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.Map;

public class ImpalaConnector extends JdbcConnector {
Expand All @@ -31,4 +34,19 @@ public ImpalaConnector(DataSourceClient dataSourceClient) {
public BaseJdbcDataSourceInfo getDatasourceInfo(Map<String,String> param) {
return new ImpalaDataSourceInfo(param);
}

@Override
public ResultSet getMetadataColumns(DatabaseMetaData metaData, String catalog, String schema, String tableName, String columnName) throws SQLException {
return metaData.getColumns(null, catalog, tableName, columnName);
}

@Override
protected ResultSet getMetadataTables(DatabaseMetaData metaData, String catalog, String schema) throws SQLException {
return metaData.getTables(null, catalog, null, TABLE_TYPES);
}

@Override
protected ResultSet getPrimaryKeys(DatabaseMetaData metaData, String catalog, String schema, String tableName) throws SQLException {
return null;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
import io.datavines.connector.api.DataSourceClient;

import java.sql.*;
import java.util.Arrays;
import java.util.List;
import java.util.Map;
import java.util.Properties;

Expand Down Expand Up @@ -95,4 +97,9 @@ public ConnectorResponse testConnect(TestConnectionRequestParam param) {
}
}

@Override
public List<String> keyProperties() {
return Arrays.asList("host","port","catalog","database");
}

}

0 comments on commit 1e94ed0

Please sign in to comment.