[improve][broker] Avoid PersistentReplicator.expireMessages logic com…

…pute backlog twice (apache#23957) (cherry picked from commit 6db275c)
datastax · Feb 11, 2025 · 921b75e · 921b75e
1 parent 77dc34d
commit 921b75e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...roker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentReplicator.java b/...roker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentReplicator.java
@@ -630,8 +630,8 @@ private long getReplicationDelayInSeconds() {
     }
 
     public boolean expireMessages(int messageTTLInSeconds) {
-        if ((cursor.getNumberOfEntriesInBacklog(false) == 0)
-                || (cursor.getNumberOfEntriesInBacklog(false) < MINIMUM_BACKLOG_FOR_EXPIRY_CHECK
+        long backlog = cursor.getNumberOfEntriesInBacklog(false);
+        if ((backlog == 0) || (backlog < MINIMUM_BACKLOG_FOR_EXPIRY_CHECK
                         && !topic.isOldestMessageExpired(cursor, messageTTLInSeconds))) {
             // don't do anything for almost caught-up connected subscriptions
             return false;