Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yarn & workspaces to v1 #190

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Bump yarn & workspaces to v1 #190

merged 1 commit into from
Apr 14, 2021

Conversation

newsroomdev
Copy link
Member

Fixes #189 #188 #187 #186

Summary

Upon further investigation, only yarn v1 is currently supported by Github's dependabot. This PR switches to yarn v1, but with the understanding that upgrading can be easily redone given both the tooling and git history. Using v1 should further increase our reliability on dependabot against security vulnerabilities going forward.

Changes

  • Removes the .yarn subdirectory and .yarnrc.yml from v2
  • Updates workflow to use v1 command
  • Updates package.json files to use yarn v1 workspace namespaces

How to review

  • Do Workflow tests pass?
  • If you pull this branch, are you still able to run Dataproofer on sample datasets?

@newsroomdev newsroomdev requested a review from ejfox March 11, 2021 03:13
@newsroomdev newsroomdev marked this pull request as ready for review April 12, 2021 22:22
Copy link
Contributor

@ejfox ejfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ejfox ejfox merged commit 8f3dd13 into dev Apr 14, 2021
@ejfox ejfox deleted the grich/yarn-v1 branch April 14, 2021 20:15
newsroomdev added a commit that referenced this pull request May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants