Remove electron references #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newsroomdev
reviewed
Mar 4, 2021
| @@ -1,11 +1,18 @@ | |||
| { | |||
| "name": "dataproofer", | |||
There was a problem hiding this comment.
interesting! silly question, won't this cause a name conflict with the other package.json named "dataproofer"? https://github.com/dataproofer/Dataproofer/blob/dev/src/package.json#L2
There was a problem hiding this comment.
oh also seeing all the tests are failing now hm
There was a problem hiding this comment.
I think it's likely this is that's what is breaking it, maybe it should be dataproofer-cli
| "private": true, | ||
| "workspaces": [ | ||
| "src", | ||
| "packages/*" | ||
| ], | ||
| "main": "./src/index.js", | ||
| "bin": { | ||
| "dataproofer": "./src/index.js" |
There was a problem hiding this comment.
i think you may need to update some of the workflows to get this passing
|
Should pull in latest yarn version updates |
newsroomdev
approved these changes
May 1, 2021
newsroomdev
pushed a commit
that referenced
this pull request
May 1, 2021
* docs: update README to remove electron references, use bin cli name * refactor: update package.json with name, version, main script, and bin Referenced https://medium.com/jspoint/creating-cli-executable-global-npm-module-5ef734febe32 * docs: remove reference to beta * docs: tweak template language * docs: update links for monorepo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes references to electron and makes it so that the script can be run by calling
dataproofer file.csvwhen installed usingnpm install -g