-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execution start and end time metadata for code cells #29
Merged
fcollonval
merged 17 commits into
datalayer:main
from
Darshan808:add-execution-timing-metadata
Jan 27, 2025
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
89402b6
add-execution-timing-metadata
Darshan808 b5d1ad7
add test for timing metadata
Darshan808 7b01c08
add additional config
Darshan808 f3e13de
lint fix
Darshan808 891a44b
add ydoc as test dependency
Darshan808 bb08e93
improve code
Darshan808 e561501
drop stop_extension() and del fim
Darshan808 7c2ac6b
add jupyter-server-fileid in test-dependencies
Darshan808 04dec3f
resolve CI stall
Darshan808 cc36797
add additional plugins
Darshan808 358ea0d
Attempt to fix the test issues, cleanup
krassowski 50701ff
merge conflict resolve
Darshan808 74eea6c
add execution start event
Darshan808 9f94617
export fix
Darshan808 535e241
code improvements
Darshan808 4b0ed4b
clear execute metadata
Darshan808 8670e7c
Also record `iopub.execute_input`
krassowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the metadata I think we will want to match the exact identifiers as used on the frontend, so instead of
start_time
we would useshell.execute_reply.started
and for end time -shell.execute_reply
- although these are less readable, it would makejupyter-server-nbmodel
a drop-in replacement and compatible with existing extensions likejupyterlab-execute-time
.There also should be
execution_failed
for when the execution fails.