Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format with black v24.2.0 #1153

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Format with black v24.2.0 #1153

merged 2 commits into from
Mar 19, 2024

Conversation

ethho
Copy link
Contributor

@ethho ethho commented Feb 21, 2024

Directories datajoint, tests, and tests_old are not compliant with the Black code style as of black v24.2.0. This causes linting errors in CI.

This PR runs the newest version of black on our codebase:

$ black datajoint tests tests_old
All done! ✨ 🍰 ✨
132 files left unchanged.
$ black --version
black, 24.2.0 (compiled: yes)
Python (CPython) 3.11.4

This PR also includes changes that standardize how black is run in CI. These changes were made to address inconsistencies in formatting between different versions of black.

@ethho ethho self-assigned this Feb 21, 2024
@ethho ethho added bug dev-process Issues related to project management, tests, etc. labels Feb 21, 2024
@ethho
Copy link
Contributor Author

ethho commented Feb 21, 2024

Besides .github/workflows/development.yaml, this PR only contains changes made by black formatting.

@ethho ethho marked this pull request as ready for review February 21, 2024 20:52
@ethho ethho mentioned this pull request Feb 21, 2024
@dimitri-yatsenko dimitri-yatsenko merged commit f357955 into master Mar 19, 2024
23 checks passed
@dimitri-yatsenko dimitri-yatsenko deleted the dev-black-format branch March 19, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dev-process Issues related to project management, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants