Make groups integration tests less flaky #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkvuong
had a problem deploying
to
account-admin
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
==========================================
+ Coverage 87.49% 87.51% +0.01%
==========================================
Files 44 44
Lines 5319 5341 +22
Branches 949 954 +5
==========================================
+ Hits 4654 4674 +20
- Misses 450 452 +2
Partials 215 215 ☔ View full report in Codecov by Sentry. |
nkvuong
had a problem deploying
to
account-admin
GitHub Actions
Failure
nkvuong
had a problem deploying
to
account-admin
GitHub Actions
Failure
nkvuong
changed the title
test_env_or_skip integration test
nkvuong
had a problem deploying
to
account-admin
GitHub Actions
Failure
nkvuong
had a problem deploying
to
account-admin
GitHub Actions
Failure
nkvuong
had a problem deploying
to
account-admin
GitHub Actions
Failure
nfx
added a commit
that referenced
this pull request
Feb 21, 2024
* Fixed `AnalysisException` in `crawl_tables` task by ignoring the database that is not found ([#970](#970)). * Fixed `Unknown: org.apache.hadoop.hive.ql.metadata.HiveException: NoSuchObjectException` in `crawl_grants` task by ignoring the database that is not found ([#967](#967)). * Fixed ruff config for ruff==2.0 ([#969](#969)). * Made groups integration tests less flaky ([#965](#965)).
Merged
nfx
added a commit
that referenced
this pull request
Feb 21, 2024
* Fixed `AnalysisException` in `crawl_tables` task by ignoring the database that is not found ([#970](#970)). * Fixed `Unknown: org.apache.hadoop.hive.ql.metadata.HiveException: NoSuchObjectException` in `crawl_grants` task by ignoring the database that is not found ([#967](#967)). * Fixed ruff config for ruff==2.0 ([#969](#969)). * Made groups integration tests less flaky ([#965](#965)).
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
## Changes - Fix `test_env_or_skip`: Skipped & Failed needs to be imported as outcomes from `_pytest` - Parametrize `test_group_name_change` suites - Change `validate_migrate_groups` to raise `NotFound`, so flaky tests can be retried ### Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [x] manually tested
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Fixed `AnalysisException` in `crawl_tables` task by ignoring the database that is not found ([#970](#970)). * Fixed `Unknown: org.apache.hadoop.hive.ql.metadata.HiveException: NoSuchObjectException` in `crawl_grants` task by ignoring the database that is not found ([#967](#967)). * Fixed ruff config for ruff==2.0 ([#969](#969)). * Made groups integration tests less flaky ([#965](#965)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
test_env_or_skip: Skipped & Failed needs to be imported as outcomes from_pytesttest_group_name_changesuitesvalidate_migrate_groupsto raiseNotFound, so flaky tests can be retriedTests