Fixec AzureResourcePermissions.load to call Installation.load #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of _installation.save
qziyuan
had a problem deploying
to
account-admin
GitHub Actions
Failure
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
=======================================
Coverage 87.49% 87.49%
=======================================
Files 44 44
Lines 5319 5319
Branches 949 949
=======================================
Hits 4654 4654
Misses 450 450
Partials 215 215 ☔ View full report in Codecov by Sentry. |
nfx
changed the title
nfx
approved these changes
Feb 20, 2024
nfx
added a commit
that referenced
this pull request
Feb 21, 2024
* Added secret detection logic to Azure service principal crawler ([#950](#950)). * Create storage credentials based on instance profiles and existing roles ([#869](#869)). * Enforced `protected-access` pylint rule ([#956](#956)). * Enforced `pylint` on unit and integration test code ([#953](#953)). * Enforcing `invalid-name` pylint rule ([#957](#957)). * Fixed AzureResourcePermissions.load to call Installation.load ([#962](#962)). * Fixed installer script to reuse an existing UCX Cluster policy if present ([#964](#964)). * More `pylint` tuning ([#958](#958)). * Refactor `workspace_client_mock` to have combine fixtures stored in separate JSON files ([#955](#955)). Dependency updates: * Updated databricks-sdk requirement from ~=0.19.0 to ~=0.20.0 ([#961](#961)).
Merged
nfx
added a commit
that referenced
this pull request
Feb 21, 2024
* Added secret detection logic to Azure service principal crawler ([#950](#950)). * Create storage credentials based on instance profiles and existing roles ([#869](#869)). * Enforced `protected-access` pylint rule ([#956](#956)). * Enforced `pylint` on unit and integration test code ([#953](#953)). * Enforcing `invalid-name` pylint rule ([#957](#957)). * Fixed AzureResourcePermissions.load to call Installation.load ([#962](#962)). * Fixed installer script to reuse an existing UCX Cluster policy if present ([#964](#964)). * More `pylint` tuning ([#958](#958)). * Refactor `workspace_client_mock` to have combine fixtures stored in separate JSON files ([#955](#955)). Dependency updates: * Updated databricks-sdk requirement from ~=0.19.0 to ~=0.20.0 ([#961](#961)).
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Added secret detection logic to Azure service principal crawler ([#950](#950)). * Create storage credentials based on instance profiles and existing roles ([#869](#869)). * Enforced `protected-access` pylint rule ([#956](#956)). * Enforced `pylint` on unit and integration test code ([#953](#953)). * Enforcing `invalid-name` pylint rule ([#957](#957)). * Fixed AzureResourcePermissions.load to call Installation.load ([#962](#962)). * Fixed installer script to reuse an existing UCX Cluster policy if present ([#964](#964)). * More `pylint` tuning ([#958](#958)). * Refactor `workspace_client_mock` to have combine fixtures stored in separate JSON files ([#955](#955)). Dependency updates: * Updated databricks-sdk requirement from ~=0.19.0 to ~=0.20.0 ([#961](#961)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AzureResourcePermissions.load should call Installation.load instead of Installation.save
Changes
Linked issues
Resolves #..
Functionality
databricks labs ucx .........Tests