Fixing installer not opening config file during the installation #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william-conti
had a problem deploying
to
account-admin
GitHub Actions
Failure
william-conti
had a problem deploying
to
account-admin
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #945 +/- ##
==========================================
+ Coverage 87.72% 87.76% +0.04%
==========================================
Files 43 43
Lines 5212 5213 +1
Branches 939 939
==========================================
+ Hits 4572 4575 +3
+ Misses 435 434 -1
+ Partials 205 204 -1 ☔ View full report in Codecov by Sentry. |
nfx
requested changes
Feb 14, 2024
There was a problem hiding this comment.
this looks like a change to https://github.com/databrickslabs/blueprint to me, not to ucx
william-conti
had a problem deploying
to
account-admin
GitHub Actions
Failure
william-conti
had a problem deploying
to
account-admin
GitHub Actions
Failure
nfx
approved these changes
Feb 14, 2024
nfx
added a commit
that referenced
this pull request
Feb 16, 2024
* Added CLI Command `databricks labs ucx principal-prefix-access` ([#949](#949)). * Added a widget with all jobs to track migration progress ([#940](#940)). * Added legacy cluster types to the assessment result ([#932](#932)). * Cleanup of install documentation ([#951](#951), [#947](#947)). * Fixed `WorkspaceConfig` initialization for `DEBUG` notebook ([#934](#934)). * Fixed installer not opening config file during the installation ([#945](#945)). * Fixed groups in config file not considered for group migration job ([#943](#943)). * Fixed bug where `tenant_id` inside secret scope is not detected ([#942](#942)).
Merged
nfx
added a commit
that referenced
this pull request
Feb 16, 2024
* Added CLI Command `databricks labs ucx principal-prefix-access` ([#949](#949)). * Added a widget with all jobs to track migration progress ([#940](#940)). * Added legacy cluster types to the assessment result ([#932](#932)). * Cleanup of install documentation ([#951](#951), [#947](#947)). * Fixed `WorkspaceConfig` initialization for `DEBUG` notebook ([#934](#934)). * Fixed installer not opening config file during the installation ([#945](#945)). * Fixed groups in config file not considered for group migration job ([#943](#943)). * Fixed bug where `tenant_id` inside secret scope is not detected ([#942](#942)).
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
## Changes `self._installation.save(config)` returns a local path from the workspace. Changed the installer to build an URL that can be resolved by webbrowser.open() ### Linked issues fixes #944 ### Functionality ### Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [X ] manually tested - [X ] added unit tests
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Added CLI Command `databricks labs ucx principal-prefix-access` ([#949](#949)). * Added a widget with all jobs to track migration progress ([#940](#940)). * Added legacy cluster types to the assessment result ([#932](#932)). * Cleanup of install documentation ([#951](#951), [#947](#947)). * Fixed `WorkspaceConfig` initialization for `DEBUG` notebook ([#934](#934)). * Fixed installer not opening config file during the installation ([#945](#945)). * Fixed groups in config file not considered for group migration job ([#943](#943)). * Fixed bug where `tenant_id` inside secret scope is not detected ([#942](#942)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
self._installation.save(config)returns a local path from the workspace.Changed the installer to build an URL that can be resolved by webbrowser.open()
Linked issues
fixes #944
Functionality
Tests