Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for issue #786. #815

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Added tests for issue #786. #815

merged 3 commits into from
Feb 12, 2024

Conversation

larsgeorge-db
Copy link
Contributor

Changes

Added unit tests and minor code tweak as a result.

Tests

  • added unit tests

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (158ae61) 87.21% compared to head (fb86cce) 87.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
+ Coverage   87.21%   87.66%   +0.45%     
==========================================
  Files          41       41              
  Lines        5200     5197       -3     
  Branches      936      937       +1     
==========================================
+ Hits         4535     4556      +21     
+ Misses        458      435      -23     
+ Partials      207      206       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't mock private properties - _state. otherwise lgtm.

Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nfx
Copy link
Collaborator

nfx commented Feb 9, 2024

@larsgeorge-db please resolve conflicts

@nfx nfx merged commit 914f0b8 into main Feb 12, 2024
6 of 7 checks passed
@nfx nfx deleted the fix/issue_786_tests branch February 12, 2024 11:25
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants