-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for issue #786. #815
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
==========================================
+ Coverage 87.21% 87.66% +0.45%
==========================================
Files 41 41
Lines 5200 5197 -3
Branches 936 937 +1
==========================================
+ Hits 4535 4556 +21
+ Misses 458 435 -23
+ Partials 207 206 -1 ☔ View full report in Codecov by Sentry. |
9c710a4
to
a399e13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't mock private properties - _state
. otherwise lgtm.
501301b
to
156dfd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@larsgeorge-db please resolve conflicts |
9e74130
to
fb86cce
Compare
Changes
Added unit tests and minor code tweak as a result.
Tests