Harden configuration reading #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Failure
nfx
requested changes
Sep 23, 2024
| value = config.get(key, {}).get("value", "") | ||
| value = config.get(key, {}) | ||
| if isinstance(value, dict): | ||
| value = value.get("value", "") |
There was a problem hiding this comment.
bug: otherwise value is None. add an else statement
There was a problem hiding this comment.
That could also happen in line 48 and the function signature allows return type None. It will break when get_secret is True
nfx
approved these changes
Sep 26, 2024
jgarciaf106
pushed a commit
to rportilla-databricks/ucx
that referenced
this pull request
Sep 26, 2024
## Changes Harden configuration reading by verifying the type before reading the "value" using `.get` ### Linked issues Resolves databrickslabs#2581 (hopefully the second get is the issue, type hinting should cover that, but who knows) ### Functionality - [x] modified existing workflow: `assessment` ### Tests - [x] added unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Harden configuration reading by verifying the type before reading the "value" using
.getLinked issues
Resolves #2581 (hopefully the second get is the issue, type hinting should cover that, but who knows)
Functionality
assessmentTests