Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting aws account id from the profile. #1718

Closed
wants to merge 2 commits into from

Conversation

FastLee
Copy link
Contributor

@FastLee FastLee commented May 19, 2024

closes #1714
Added lookup for AWS account id from the AWS profile.

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.26%. Comparing base (0045aa1) to head (a66b872).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage   89.25%   89.26%           
=======================================
  Files          88       88           
  Lines       11219    11222    +3     
  Branches     1982     1983    +1     
=======================================
+ Hits        10014    10017    +3     
  Misses        822      822           
  Partials      383      383           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FastLee FastLee marked this pull request as ready for review May 19, 2024 19:52
@FastLee FastLee requested review from a team and mwojtyczka May 19, 2024 19:52
@FastLee FastLee temporarily deployed to account-admin May 19, 2024 19:52 — with GitHub Actions Inactive
@nkvuong
Copy link
Contributor

nkvuong commented May 19, 2024

I've already opened the PR #1715 :)

Copy link

✅ 168/168 passed, 25 skipped, 4h48m16s total

Running from acceptance #3302

@FastLee FastLee enabled auto-merge May 20, 2024 13:27
@FastLee FastLee disabled auto-merge May 20, 2024 13:36
@FastLee FastLee closed this May 20, 2024
@nfx nfx deleted the bug/aws-populate-account-id branch July 19, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: aws_account_id is None when creating uber principal
2 participants