Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for linting task with pip dependency #1702

Merged

Conversation

JCZuurmond
Copy link
Member

@JCZuurmond JCZuurmond commented May 16, 2024

Changes

Add an integration test validating a library import can not be resolved if the PyPI dependency is not defined.

Linked issues

Part of #1642

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs ucx ...
  • added a new workflow
  • modified existing workflow: ...
  • added a new table
  • modified existing table: ...

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • verified on staging environment (screenshot attached)

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (08aed28) to head (17c0ab5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1702   +/-   ##
=======================================
  Coverage   89.22%   89.22%           
=======================================
  Files          88       88           
  Lines       11127    11127           
  Branches     1959     1959           
=======================================
  Hits         9928     9928           
  Misses        821      821           
  Partials      378      378           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JCZuurmond JCZuurmond enabled auto-merge May 16, 2024 14:11
Copy link

✅ 167/167 passed, 3 flaky, 25 skipped, 2h33m7s total

Flaky tests:

  • 🤪 test_create_catalog_schema_with_principal_acl_CLOUD_ENV (1m4.804s)
  • 🤪 test_running_real_remove_backup_groups_job (4m54.667s)
  • 🤪 test_running_real_migrate_groups_job (8m50.543s)

Running from acceptance #3242

@JCZuurmond JCZuurmond added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit a42a83b May 16, 2024
8 checks passed
@JCZuurmond JCZuurmond deleted the feat/add-integration-test-for-linting-task-with-pip-dependency branch May 16, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants