Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert if group name is in cluster policy #1665

Merged
merged 1 commit into from
May 8, 2024
Merged

Assert if group name is in cluster policy #1665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/integration/test_ext_hms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,4 +170,5 @@ def test_running_real_assessment_job_ext_hms(
assert ext_hms_ctx.deployed_workflows.validate_step("assessment")

after = ext_hms_ctx.generic_permissions_support.load_as_dict("cluster-policies", cluster_policy.policy_id)
assert ws_group_a.display_name in after, f"Group {ws_group_a.display_name} not found in cluster policy"
assert after[ws_group_a.display_name] == PermissionLevel.CAN_USE
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkvuong : Do you remember why this assert is there? This does not look like something done during the assessment, but something done with the test setup (line 159 to 163).

I expect this test to fail in the nightly run when we hit a limit for creating (account) groups and are throttled by Databricks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a copy of test_running_real_assessment_job, except that it is set up with external hms. My reading of the test is that it is asserting that the permission is crawled correctly by the assessment job

Loading