Create Databricks access connector #1376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
requested changes
Apr 12, 2024
|
Perhaps the user assigned identity is not necessary - https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/databricks_access_connector |
To be used for manual testing
JCZuurmond
commented
Apr 12, 2024
JCZuurmond
force-pushed
the
feature/handle-access-connector-managed-identity
branch
from
52592b5 to
420d6eb
Compare
JCZuurmond
commented
Apr 16, 2024
| @@ -21,16 +24,23 @@ | |||
| @dataclass | |||
| class StoragePermissionMapping: | |||
There was a problem hiding this comment.
@nfx : The change to this data class blew up the PR.
- I will separate the PR to make it easier to comprehend and review.
- I would like your input on if we can circumvent this change. Specifically the
role_name, which is required to track the storage permission, so that we can set the appropriate permission level for the access connectors. TheStoragePermissionMappingcontains the Databricks privilege, however, this does not map to the Azure storage permissions. -> We could neglect the "Storage Blob Data Owner", give "Storage Blob Data Contributor" as highest permission as the access connectors should not be used to do POSIX access control
|
First merge: #1417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Linked issues
Resolves #888
Functionality
databricks labs ucx .........Tests