Skip to content

Commit

Permalink
Remove unused current working directory context manager
Browse files Browse the repository at this point in the history
  • Loading branch information
JCZuurmond committed May 31, 2024
1 parent 9f66e5a commit 6c7ae59
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 18 deletions.
12 changes: 0 additions & 12 deletions src/databricks/labs/ucx/source_code/python_libraries.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@
from __future__ import annotations

import logging
import os
import tempfile
import zipfile
from collections.abc import Callable, Iterator
from contextlib import contextmanager
from functools import cached_property
from pathlib import Path

Expand All @@ -23,16 +21,6 @@
logger = logging.getLogger(__name__)


@contextmanager
def current_working_directory(path: Path) -> Iterator[Path]:
old_working_directory = Path.cwd()
os.chdir(path)
try:
yield path
finally:
os.chdir(old_working_directory)


class PythonLibraryResolver(LibraryResolver):
# TODO: https://github.com/databrickslabs/ucx/issues/1640

Expand Down
7 changes: 1 addition & 6 deletions tests/unit/source_code/test_python_libraries.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,10 @@

from databricks.labs.ucx.source_code.graph import DependencyProblem
from databricks.labs.ucx.source_code.path_lookup import PathLookup
from databricks.labs.ucx.source_code.python_libraries import PythonLibraryResolver, current_working_directory
from databricks.labs.ucx.source_code.python_libraries import PythonLibraryResolver
from databricks.labs.ucx.source_code.known import Whitelist


def test_current_working_directory(tmp_path):
with current_working_directory(tmp_path):
assert Path.cwd() == tmp_path


def test_pip_resolver_resolves_library(mock_path_lookup):
def mock_pip_install(command):
assert command.startswith("pip install anything -t")
Expand Down

0 comments on commit 6c7ae59

Please sign in to comment.