Skip to content

Commit

Permalink
Explain why we skip system groups
Browse files Browse the repository at this point in the history
  • Loading branch information
JCZuurmond committed Oct 17, 2024
1 parent 486b6df commit 65e936e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/databricks/labs/ucx/hive_metastore/grants.py
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ def _get_external_locations(


class PrincipalACL:
_system_groups = {"admins", "users"}
_workspace_system_groups = {"admins", "users"}

def __init__(
self,
Expand Down Expand Up @@ -694,7 +694,7 @@ def _get_cluster_principal_mapping(self, cluster_id: str, object_type: str) -> l
if acl.user_name is not None:
principal_list.append(acl.user_name)
if acl.group_name is not None:
if acl.group_name in self._system_groups:
if acl.group_name in self._workspace_system_groups: # Do not exists on account level
continue
principal_list.append(acl.group_name)
if acl.service_principal_name is not None:
Expand Down

0 comments on commit 65e936e

Please sign in to comment.