Add workspace import-dir command

[shreyas-goenka]

Tests

Testing using integration tests and manually

[shreyas-goenka]

case 1: target directory does not exist

shreyas.goenka@THW32HFW6T vandaley-industries % cli workspace import-dir foo /Users/[email protected]/remote-dir
.gitignore -> /Users/[email protected]/remote-dir/.gitignore
apple -> /Users/[email protected]/remote-dir/apple
hello_world.py -> /Users/[email protected]/remote-dir/hello_world
mango -> /Users/[email protected]/remote-dir/mango
veggies/tomatoes -> /Users/[email protected]/remote-dir/veggies/tomatoes

case 2: A few preexisting files at target dir

shreyas.goenka@THW32HFW6T vandaley-industries % cli workspace import-dir foo /Users/[email protected]/remote-dir
.gitignore -> /Users/[email protected]/remote-dir/.gitignore (skipped; already exists)
apple -> /Users/[email protected]/remote-dir/apple
hello_world.py -> /Users/[email protected]/remote-dir/hello_world (skipped; already exists)
mango -> /Users/[email protected]/remote-dir/mango
veggies/tomatoes -> /Users/[email protected]/remote-dir/veggies/tomatoes

case 3: preexisting files, but overwrite flag is set

shreyas.goenka@THW32HFW6T vandaley-industries % cli workspace import-dir foo /Users/[email protected]/remote-dir --overwrite
.gitignore -> /Users/[email protected]/remote-dir/.gitignore
apple -> /Users/[email protected]/remote-dir/apple
hello_world.py -> /Users/[email protected]/remote-dir/hello_world
mango -> /Users/[email protected]/remote-dir/mango
veggies/tomatoes -> /Users/[email protected]/remote-dir/veggies/tomatoes

case 4: json output mode

shreyas.goenka@THW32HFW6T vandaley-industries % cli workspace import-dir foo /Users/[email protected]/remote-dir --overwrite --output=json
{
  "source_path":"/Users/shreyas.goenka/projects/vandaley-industries/foo",
  "type":"IMPORT_STARTED"
}
{
  "source_path":".gitignore",
  "target_path":"/Users/[email protected]/remote-dir/.gitignore",
  "type":"FILE_IMPORTED"
}
{
  "source_path":"apple",
  "target_path":"/Users/[email protected]/remote-dir/apple",
  "type":"FILE_IMPORTED"
}
{
  "source_path":"hello_world.py",
  "target_path":"/Users/[email protected]/remote-dir/hello_world",
  "type":"FILE_IMPORTED"
}
{
  "source_path":"mango",
  "target_path":"/Users/[email protected]/remote-dir/mango",
  "type":"FILE_IMPORTED"
}
{
  "source_path":"veggies/tomatoes",
  "target_path":"/Users/[email protected]/remote-dir/veggies/tomatoes",
  "type":"FILE_IMPORTED"
}
{
  "target_path":"/Users/[email protected]/remote-dir",
  "type":"IMPORT_COMPLETED"
}
shreyas.goenka@THW32HFW6T vandaley-industries %

[pietern]

Final minor issues. Everything else LGTM.

[s4m0r4m4]

@shreyas-goenka It looks like this did not make it into the docs, should I spin up a new ticket for that?

https://github.com/databricks/cli/blob/main/docs/commands.md#databricks-workspace---the-workspace-api-allows-you-to-list-import-export-and-delete-notebooks-and-folders

[pietern]

@s4m0r4m4 Thanks for noticing. That doc hasn't been updated after it was first added (we don't have automation for it). Out of curiosity -- are you actively using that as a reference?

[s4m0r4m4]

I am! I used to use the legacy documentation and was trying to upgrade and use the newer documentation but it doesn't seem to be quite as fleshed out as the older stuff

[pietern]

Understood -- yeah, the docs were autogenerated from our API explorer, so the manually curated commands didn't show up there. I filed issue #829 to track this.