acc: Fix RecordRequests to support requests without body #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
requested review from
pietern,
andrewnester and
shreyas-goenka
as code owners
denik
changed the title
denik
force-pushed
the
denik/record-requests-no-body
branch
from
4422e74 to
7eacb4c
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/verify-local-test
branch
from
8b5891f to
feb1beb
Compare
denik
force-pushed
the
denik/record-requests-no-body
branch
from
7eacb4c to
87e11c6
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Only disallow RecordRequests & CLOUD_ENV. Having [[Server]] is okay - we just should not use it. don't raise
denik
force-pushed
the
denik/verify-local-test
branch
from
feb1beb to
7c3ee39
Compare
denik
force-pushed
the
denik/record-requests-no-body
branch
from
87e11c6 to
c89fd8a
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Do not paste request body into output if it's not a valid JSON.
Tests
While working on #2334 I found that if I try to record a test that calls /api/2.0/preview/scim/v2/Me which has no request body, it crashes.