Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acc: Do not show all replacements on every failure #2331

Merged
merged 3 commits into from
Feb 11, 2025
Merged

acc: Do not show all replacements on every failure #2331

merged 3 commits into from
Feb 11, 2025

Conversation

denik
Copy link
Contributor

@denik denik commented Feb 10, 2025 •
edited
Loading

Changes

  • Only print replacements if VERBOSE_TEST flag is set.
  • This is set on CI but not when you do "go test" or "make test".

Note, env var is used, so that it can be set in Makefile.

Tests

Manually.

@denik denik temporarily deployed to test-trigger-is February 10, 2025 21:07 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is February 10, 2025 21:13 — with GitHub Actions Inactive
@denik denik changed the title acc: Add -verbosetest option acc: Do not show all replacements on every failure Feb 10, 2025
@denik denik marked this pull request as ready for review February 10, 2025 21:34
@denik denik enabled auto-merge February 10, 2025 21:38
@denik denik added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit f2096ed Feb 11, 2025
9 checks passed
@denik denik deleted the denik/verbosetest branch February 11, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-goenka shreyas-goenka shreyas-goenka approved these changes

@pietern pietern Awaiting requested review from pietern pietern is a code owner

@andrewnester andrewnester Awaiting requested review from andrewnester andrewnester is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denik @shreyas-goenka