Remove terraform acceptance test #2286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
@denik What do you think? Having this test just around for debugging / development seems like more pain than it's worth but I'm curious. What exactly is the motivation behind this test? Maybe we can have something that's narrower in scope or just a README? |
shreyas-goenka
requested review from
pietern,
andrewnester and
denik
as code owners
|
The test is actually pretty stable and if it becomes not so stable, we can disable it in the cloud. However, it is useful to debug terrraform configuration issues. It is also useful as a base to extend to quickly test how a given terraform configuration works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This test does not provide any additional product coverage and has a maintenance burden. Examples of this in action include: