Fix env variable for AzureCli local config #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikjansen-hu
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
Thanks for you contribution @rikjansen-hu ! At the moment we require new contributors to sign CLA in order for their change to be accepted. If that's something that you can do, please reach out to [email protected] and we will take it from there |
andrewnester
approved these changes
Feb 4, 2025
|
Merged! Thank you for your contribution! |
|
Pleasure all mine! |
andrewnester
added a commit
that referenced
this pull request
Feb 12, 2025
Bundles: * Added support to generate Git based jobs ([#2304](#2304)). * Added support for run_as in pipelines ([#2287](#2287)). * Raise an error when there are multiple local libraries with the same basename used ([#2297](#2297)). * Fix env variable for AzureCli local config ([#2248](#2248)). * Accept JSON files in includes section ([#2265](#2265)). * Always print warnings and errors; clean up format ([#2213](#2213)) API Changes: * Added `databricks account budget-policy` command group. * Added `databricks lakeview-embedded` command group. * Added `databricks query-execution` command group. * Changed `databricks serving-endpoints http-request` command to type `databricks serving-endpoints http-request` command. * Added `databricks account enable-ip-access-lists` command group. * Added `databricks redash-config` command group. OpenAPI commit c72c58f97b950fcb924a90ef164bcb10cfcd5ece (2025-02-03) Dependency updates: * Upgrade to TF provider 1.65.1 ([#2328](#2328)). * Bump golangci/golangci-lint-action from 6.1.1 to 6.2.0 ([#2273](#2273)). * Bump astral-sh/ruff-action from 3.0.1 to 3.1.0 ([#2274](#2274)). * Bump actions/stale from 9.0.0 to 9.1.0 ([#2275](#2275)). * Bump actions/create-github-app-token from 1.11.1 to 1.11.2 ([#2276](#2276)). * Bump github.com/hashicorp/terraform-exec from 0.21.0 to 0.22.0 ([#2237](#2237)). * Bump github.com/spf13/pflag from 1.0.5 to 1.0.6 ([#2281](#2281)). * Bump github.com/databricks/databricks-sdk-go from 0.56.1 to 0.57.0 ([#2321](#2321)). * Bump golang.org/x/oauth2 from 0.25.0 to 0.26.0 ([#2322](#2322)). * Bump golang.org/x/term from 0.28.0 to 0.29.0 ([#2325](#2325)). * Bump golang.org/x/text from 0.21.0 to 0.22.0 ([#2323](#2323)). * Bump golang.org/x/mod from 0.22.0 to 0.23.0 ([#2324](#2324)).
andrewnester
added a commit
that referenced
this pull request
Feb 12, 2025
Bundles: * Added support to generate Git based jobs ([#2304](#2304)). * Added support for run_as in pipelines ([#2287](#2287)). * Raise an error when there are multiple local libraries with the same basename used ([#2297](#2297)). * Fix env variable for AzureCli local config ([#2248](#2248)). * Accept JSON files in includes section ([#2265](#2265)). * Always print warnings and errors; clean up format ([#2213](#2213)) API Changes: * Added `databricks account budget-policy` command group. * Added `databricks lakeview-embedded` command group. * Added `databricks query-execution` command group. * Added `databricks account enable-ip-access-lists` command group. * Added `databricks redash-config` command group. OpenAPI commit c72c58f97b950fcb924a90ef164bcb10cfcd5ece (2025-02-03) Dependency updates: * Upgrade to TF provider 1.65.1 ([#2328](#2328)). * Bump github.com/hashicorp/terraform-exec from 0.21.0 to 0.22.0 ([#2237](#2237)). * Bump github.com/spf13/pflag from 1.0.5 to 1.0.6 ([#2281](#2281)). * Bump github.com/databricks/databricks-sdk-go from 0.56.1 to 0.57.0 ([#2321](#2321)). * Bump golang.org/x/oauth2 from 0.25.0 to 0.26.0 ([#2322](#2322)). * Bump golang.org/x/term from 0.28.0 to 0.29.0 ([#2325](#2325)). * Bump golang.org/x/text from 0.21.0 to 0.22.0 ([#2323](#2323)). * Bump golang.org/x/mod from 0.22.0 to 0.23.0 ([#2324](#2324)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Solves #1722 (current solution passes wrong variable)
Tests
None, this is a simple find-and-replace on a previous PR.
Proof that this is the correct variable.
This just passes the variable along to the Terraform environment, which should be picked up by Terraform.