Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New CLI doesn't support automatic detection of Git providers #527

Closed
alexott opened this issue Jun 26, 2023 · 2 comments · Fixed by #528
Closed

New CLI doesn't support automatic detection of Git providers #527

alexott opened this issue Jun 26, 2023 · 2 comments · Fixed by #528
Assignees
@pietern

Comments

@alexott
Copy link
Collaborator

alexott commented Jun 26, 2023

Right now the Git provider name is a required argument, while old CLI was able to deduce "well-known" Git providers automatically, based on the Repo URL: https://github.com/databricks/databricks-cli/blob/main/databricks_cli/sdk/service.py#L1582 - it was very convenient.
@pietern pietern mentioned this issue Jun 26, 2023
Merged
@pietern
Copy link
Contributor

pietern commented Jun 26, 2023

@alexott Please take a look at the linked PR; it should do the trick.

@pietern pietern self-assigned this Jun 26, 2023
@alexott
Copy link
Collaborator Author

alexott commented Jun 27, 2023

We also don't print allowed provider values in the help.

pietern added a commit that referenced this issue Jun 27, 2023
@pietern
Add provider detection to the repos create command (#528)
c64a333 
## Changes

Closes #527.

## Tests

Integration tests pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pietern pietern

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add provider detection to the repos create command databricks/cli
2 participants
@pietern @alexott