Added async support & cleaned the constructor a little. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(caution: used github editor to propose this update) Because async file-access is one of the strengths of node I was thinking that this lib could use a little async support. I haven't tested any of this but it looks like it could work :)
|
Hi, First of all, thanks for your contribution Furthermore, I will accept this pull request and update the NPM as soon as I fix jshint errors. Cheers! |
heldr
added a commit
that referenced
this pull request
Sep 14, 2013
Added async support & cleaned the constructor a little.
heldr
added a commit
that referenced
this pull request
Sep 14, 2013
|
@martinheidegger Hi! I've just released the version 0.3.0 Some changes may affect the way you've done async through this module. More info on Api Docs. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(caution: used github editor to propose this update)
Because async file-access is one of the strengths of node I was thinking that this lib could use a little async support. I haven't tested any of this but it looks like it could work :)