schema: Memory thresholds should never be exactly 0.0. #7458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the config, memory thresholds such as
distributed.worker.memory.terminate
should never be exactly0.0
.Instead, config should use
false
to disable memory management.This one bit me recently. My older dask config files used
0.0
to disable the memory management features. That worked because older versions ofdistributed
interpreted the value0.0
to be equivalent tofalse
for these fields. But in newer versions, onlyfalse
works. (I suspect the change occurred in #5904.)Nowadays, if the config says
0.0
, thendistributed
interprets that literally -- and no memory can be used at all without incurring the wrath of the memory manager!An easy "fix" is to disallow
0.0
in the user's config. In json schema,exclusiveMinimum: 0
ensures that the value0.0
itself is not permitted by the schema.pre-commit run --all-files