Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak in test_localcluster_get_client #6817

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Fix leak in test_localcluster_get_client #6817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions distributed/deploy/tests/test_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,12 +1269,13 @@ def test_localcluster_start_exception(loop):
pass


def test_localcluster_get_client():
def test_localcluster_get_client(loop):
with LocalCluster(
n_workers=0, asynchronous=False, dashboard_address=":0"
n_workers=0, asynchronous=False, dashboard_address=":0", loop=loop
) as cluster:
client1 = cluster.get_client()
assert client1.cluster == cluster
client2 = Client(cluster)
assert client1 != client2
assert client2 == cluster.get_client()
with cluster.get_client() as client1:
assert client1.cluster == cluster

with Client(cluster) as client2:
assert client1 != client2
assert client2 == cluster.get_client()