Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace gen.coroutine usage with async def #6262

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

replace gen.coroutine usage with async def #6262

wants to merge 2 commits into from

Conversation

sjperkins
Copy link
Member

@sjperkins sjperkins commented May 3, 2022 •
edited
Loading

Closes #6221

  • Tests added / passed
  • Passes pre-commit run --all-files

@sjperkins sjperkins changed the title @gen.coroutine -> async replace gen.coroutine usage with async def May 3, 2022
@sjperkins sjperkins marked this pull request as draft May 3, 2022 11:20
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

Unit Test Results

       16 files  ±0         16 suites  ±0   8h 6m 14s ⏱️ +22s
  2 745 tests ±0    2 653 ✔️  -   8       80 💤 ±0  12 ❌ +  8 
21 861 runs  ±0  20 750 ✔️  - 61  1 045 💤  - 1  66 ❌ +62 

For more details on these failures, see this check.

Results for commit 3b08d5a. ± Comparison against base commit c11c8ee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjetter fjetter Awaiting requested review from fjetter fjetter will be requested when the pull request is marked ready for review fjetter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace gen.coroutine usage with async def
1 participant
@sjperkins