-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tiny test for ToPickle #6021
Conversation
Unit Test Results 17 files + 6 17 suites +6 9h 5m 22s ⏱️ + 3h 24m 26s For more details on these failures, see this check. Results for commit 2ac24e5. ± Comparison against base commit ed48736. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I suggest that the test is moved to test_to_pickle.py
.
Planning to merge when CI finishes. |
Also, it looks like ToPickle fails with inproc comms. |
Maybe we need this? diff --git a/distributed/protocol/serialize.py b/distributed/protocol/serialize.py
index b4daf5bd..48091cc5 100644
--- a/distributed/protocol/serialize.py
+++ b/distributed/protocol/serialize.py
@@ -611,8 +611,12 @@ def nested_deserialize(x):
x[k] = replace_inner(v)
elif typ is Serialize:
x[k] = v.data
+ elif typ is ToPickle:
+ x[k] = v.data
elif typ is Serialized:
x[k] = deserialize(v.header, v.frames)
+ elif typ is Pickled:
+ x[k] = pickle.loads(v.header, buffers=v.frames)
elif type(x) is list:
x = list(x)
@@ -622,8 +626,12 @@ def nested_deserialize(x):
x[k] = replace_inner(v)
elif typ is Serialize:
x[k] = v.data
+ elif typ is ToPickle:
+ x[k] = v.data
elif typ is Serialized:
x[k] = deserialize(v.header, v.frames)
+ elif typ is Pickled:
+ x[k] = pickle.loads(v.header, buffers=v.frames)
return x
|
#6044 should fix the |
pre-commit run --all-files