Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test_restart_sync_no_center #5994

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

mrocklin
Copy link
Member

This test is ANCIENT. "Center" was the original term for "Scheduler"
back when only I was writing on this thing.

Anyway, this test was behaving oddly. I'm shifting it to a gen_cluster
test and I suspect that that will either help things to work, or at
least will give us a lot more visibility about why it isn't working.

This test is ANCIENT.  "Center" was the original term for "Scheduler"
back when only I was writing on this thing.

Anyway, this test was behaving oddly.  I'm shifting it to a gen_cluster
test and I suspect that that will either help things to work, or at
least will give us a lot more visibility about why it isn't working.
@jakirkham jakirkham mentioned this pull request Mar 24, 2022
3 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022

Unit Test Results

       12 files  ±0         12 suites  ±0   6h 32m 58s ⏱️ + 13m 56s
  2 668 tests  - 1    2 584 ✔️  - 3    81 💤 ±0  2 +1  1 🔥 +1 
15 921 runs   - 5  15 060 ✔️  - 2  857 💤  - 6  2 +1  2 🔥 +2 

For more details on these failures and errors, see this check.

Results for commit 2f1088d. ± Comparison against base commit 5c7d555.

♻️ This comment has been updated with latest results.

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test is redundant. We have test_restart and test_restart_sync that are covering this case already, aren't they?

I don't really understand the no_center reference. Even if "translated" to no_scheduler, it appears that the original intent of this test has been lost a while ago. I'm pretty sure there is a scheduler in this test

@mrocklin
Copy link
Member Author

I'm ok removing it entirely. I've just pushed that change.

@fjetter fjetter changed the title Convert test_restart_sync_no_center Remove test_restart_sync_no_center Mar 25, 2022
@fjetter fjetter merged commit 7bb02c0 into dask:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants